GN build fixes, mostly for Mac.

build/config/clang/BUILD.gn

Index: build/config/clang/BUILD.gn
diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn
index 9f99755a5f4f6836eb444b85a9480f1c15e8960d..c3ee5da72d876b32d2508dad69f3879ba7c18ea6 100644
--- a/build/config/clang/BUILD.gn
+++ b/build/config/clang/BUILD.gn
@@ -15,7 +15,7 @@ config("find_bad_constructs") {
       "-Xclang",
     ]
 
-    if (is_mac) {
+    if (is_mac || is_ios) {

[Nico, 2014/01/27 19:42:27]

Same comment here.

The clang / plugin stuff needs to be in a <(GENERATOR)==ninja block on ios (set
some ios_cflags define in that conditional, add that to the regular flags)

[brettw, 2014/01/28 02:13:42]

Yeah, I'm still trying to figure out what to do about this. I'm hoping to hack
some special cases into my GYP generator, but may end up needing to parameterize
the entire build on the GYP generator and writing out all the flags and such
twice in the resulting GYP file.

       cflags += [ rebase_path(
         "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib",
         ".", root_build_dir) ]