GN build fixes, mostly for Mac.

build/config/clang/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   # Indicates if the build should use the Chrome-specific plugins for enforcing
   # coding guidelines, etc.
   clang_use_chrome_plugins = true
 }
 
 config("find_bad_constructs") {
   if (clang_use_chrome_plugins) {
     cflags = [
       "-Xclang", "-load",
       "-Xclang",
     ]
 
-    if (is_mac) {
+    if (is_mac || is_ios) {

[Nico, 2014/01/27 19:42:27]

Same comment here.

The clang / plugin stuff needs to be in a <(GENERATOR)==ninja block on ios (set
some ios_cflags define in that conditional, add that to the regular flags)

[brettw, 2014/01/28 02:13:42]

Yeah, I'm still trying to figure out what to do about this. I'm hoping to hack
some special cases into my GYP generator, but may end up needing to parameterize
the entire build on the GYP generator and writing out all the flags and such
twice in the resulting GYP file.

       cflags += [ rebase_path(
         "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib",
         ".", root_build_dir) ]
     } else if (is_linux) {
       cflags += [ rebase_path(
         "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
         ".", root_build_dir) ]
     }
 
     cflags += [
       "-Xclang", "-add-plugin",
       "-Xclang", "find-bad-constructs",
     ]
   }
 }