Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: net/http/url_security_manager_unittest.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reply to comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/url_security_manager_unittest.cc
diff --git a/net/http/url_security_manager_unittest.cc b/net/http/url_security_manager_unittest.cc
index 8e6d8c5cb9c7b5b684a04ec407d9fafd1b92543b..0e73628a74558e10ecd33f0a1ec1e6259f839423 100644
--- a/net/http/url_security_manager_unittest.cc
+++ b/net/http/url_security_manager_unittest.cc
@@ -49,7 +49,9 @@ TEST(URLSecurityManager, UseDefaultCredentials) {
ASSERT_TRUE(auth_filter);
// The URL security manager takes ownership of |auth_filter|.
scoped_ptr<URLSecurityManager> url_security_manager(
- URLSecurityManager::Create(auth_filter, NULL));
+ URLSecurityManager::Create());
+ url_security_manager->SetDefaultWhitelist(
+ scoped_ptr<net::HttpAuthFilter>(auth_filter));
ASSERT_TRUE(url_security_manager.get());
for (size_t i = 0; i < arraysize(kTestDataList); ++i) {
@@ -68,7 +70,9 @@ TEST(URLSecurityManager, CanDelegate) {
ASSERT_TRUE(auth_filter);
// The URL security manager takes ownership of |auth_filter|.
scoped_ptr<URLSecurityManager> url_security_manager(
- URLSecurityManager::Create(NULL, auth_filter));
+ URLSecurityManager::Create());
+ url_security_manager->SetDelegateWhitelist(
+ scoped_ptr<net::HttpAuthFilter>(auth_filter));
ASSERT_TRUE(url_security_manager.get());
for (size_t i = 0; i < arraysize(kTestDataList); ++i) {
@@ -82,7 +86,7 @@ TEST(URLSecurityManager, CanDelegate) {
TEST(URLSecurityManager, CanDelegate_NoWhitelist) {
// Nothing can delegate in this case.
scoped_ptr<URLSecurityManager> url_security_manager(
- URLSecurityManager::Create(NULL, NULL));
+ URLSecurityManager::Create());
ASSERT_TRUE(url_security_manager.get());
for (size_t i = 0; i < arraysize(kTestDataList); ++i) {

Powered by Google App Engine
This is Rietveld 408576698