Allow dynamic updating of authentication policies

net/http/url_security_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/url_security_manager.h"
 
 #include "base/basictypes.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_auth_filter.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 26 matching lines @@
   { "http://baz", true, true },
   { "http://www.exampl.com", false, false },
   { "http://example.org", false, false },
   { "http://foobar.net", false, false },
   { "http://boo.fubar.com", false, false },
 };
 
 }  // namespace
 
 TEST(URLSecurityManager, UseDefaultCredentials) {
   HttpAuthFilterWhitelist* auth_filter = new HttpAuthFilterWhitelist(

[cbentzel, 2015/12/01 20:56:16]

Nit: Maybe make |auth_filter| a scoped_ptr?

[aberent, 2015/12/02 13:30:19]

Done.

       kTestAuthWhitelist);
   ASSERT_TRUE(auth_filter);
   // The URL security manager takes ownership of |auth_filter|.
   scoped_ptr<URLSecurityManager> url_security_manager(
-      URLSecurityManager::Create(auth_filter, NULL));
+      URLSecurityManager::Create());
+  url_security_manager->SetDefaultWhitelist(
+      scoped_ptr<net::HttpAuthFilter>(auth_filter));
   ASSERT_TRUE(url_security_manager.get());
 
   for (size_t i = 0; i < arraysize(kTestDataList); ++i) {
     GURL gurl(kTestDataList[i].url);
     bool can_use_default =
         url_security_manager->CanUseDefaultCredentials(gurl);
 
     EXPECT_EQ(kTestDataList[i].succeeds_in_whitelist, can_use_default)
         << " Run: " << i << " URL: '" << gurl << "'";
   }
 }
 
 TEST(URLSecurityManager, CanDelegate) {
   HttpAuthFilterWhitelist* auth_filter = new HttpAuthFilterWhitelist(
       kTestAuthWhitelist);
   ASSERT_TRUE(auth_filter);
   // The URL security manager takes ownership of |auth_filter|.
   scoped_ptr<URLSecurityManager> url_security_manager(
-      URLSecurityManager::Create(NULL, auth_filter));
+      URLSecurityManager::Create());
+  url_security_manager->SetDelegateWhitelist(
+      scoped_ptr<net::HttpAuthFilter>(auth_filter));
   ASSERT_TRUE(url_security_manager.get());
 
   for (size_t i = 0; i < arraysize(kTestDataList); ++i) {
     GURL gurl(kTestDataList[i].url);
     bool can_delegate = url_security_manager->CanDelegate(gurl);
     EXPECT_EQ(kTestDataList[i].succeeds_in_whitelist, can_delegate)
         << " Run: " << i << " URL: '" << gurl << "'";
   }
 }
 
 TEST(URLSecurityManager, CanDelegate_NoWhitelist) {
   // Nothing can delegate in this case.
   scoped_ptr<URLSecurityManager> url_security_manager(
-      URLSecurityManager::Create(NULL, NULL));
+      URLSecurityManager::Create());
   ASSERT_TRUE(url_security_manager.get());
 
   for (size_t i = 0; i < arraysize(kTestDataList); ++i) {
     GURL gurl(kTestDataList[i].url);
     bool can_delegate = url_security_manager->CanDelegate(gurl);
     EXPECT_FALSE(can_delegate);
   }
 }
 
 
 }  // namespace net