Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1414193004: Once the flow thread needs layout, mark all column sets for layout as well. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Once the flow thread needs layout, mark all column sets for layout as well. We need this to make sure that overflow is updated. Laying out a column set is very cheap anyway, since they never have children. Since we now do this, we can remove a few setNeedsLayout calls scattered around the code. BUG=540512 R=leviw@chromium.org Committed: https://crrev.com/bf1899ac2a9209c1d2a970d298290f54bd91d1e3 Cr-Commit-Position: refs/heads/master@{#355568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/dynamic/remove-content-from-scrollable.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/dynamic/remove-content-from-scrollable-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 4 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-22 11:43:11 UTC) #1
leviw_travelin_and_unemployed
Woot! Way better. LGTM.
5 years, 2 months ago (2015-10-22 17:19:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414193004/1
5 years, 2 months ago (2015-10-22 17:20:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 17:35:14 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 17:35:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf1899ac2a9209c1d2a970d298290f54bd91d1e3
Cr-Commit-Position: refs/heads/master@{#355568}

Powered by Google App Engine
This is Rietveld 408576698