third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp - Issue 1414193004: Once the flow thread needs layout, mark all column sets for layout as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 1414193004: Once the flow thread needs layout, mark all column sets for layout as well. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

index be4f84ef57a97144b1927eaec772ad6f28cecf90..b695356cea3bc2c030ff1c876937aa416bb3aa41 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

@@ -54,8 +54,6 @@ void MultiColumnFragmentainerGroup::resetColumnHeight()

m_maxColumnHeight = calculateMaxColumnHeight();

- LayoutUnit oldColumnHeight = m_columnHeight;

LayoutMultiColumnFlowThread* flowThread = m_columnSet.multiColumnFlowThread();

LayoutMultiColumnFlowThread* enclosingFlowThread = flowThread->enclosingFlowThread();

if (enclosingFlowThread && enclosingFlowThread->isPageLogicalHeightKnown()) {

@@ -68,9 +66,6 @@ void MultiColumnFragmentainerGroup::resetColumnHeight()

} else {

setAndConstrainColumnHeight(heightAdjustedForRowOffset(flowThread->columnHeightAvailable()));

}

- if (m_columnHeight != oldColumnHeight)

- m_columnSet.setChildNeedsLayout(MarkOnlyThis);

}

bool MultiColumnFragmentainerGroup::recalculateColumnHeight(BalancedColumnHeightCalculation calculationMode)

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('k') | no next file » | no next file with comments »