Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1413933005: [turbofan] Fix bailout for script context creation. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bailout for script context creation. This fixes the bailout point used by JSCreateScriptContext nodes for top-level code. The bailout point differs from the Crankshaft one as parameter slots have not been copied and the context chain was not extended yet in TurboFan. Hence a new bailout id is required. R=ishell@chromium.org TEST=cctest/test-decls/CrossScript --turbo-inlining Committed: https://crrev.com/62e04d3382e91766fbcc122cd191d27b49d288f8 Cr-Commit-Position: refs/heads/master@{#31399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 2 chunks +8 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-20 07:49:45 UTC) #2
Igor Sheludko
lgtm
5 years, 2 months ago (2015-10-20 08:01:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413933005/1
5 years, 2 months ago (2015-10-20 08:08:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 08:14:57 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 08:15:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e04d3382e91766fbcc122cd191d27b49d288f8
Cr-Commit-Position: refs/heads/master@{#31399}

Powered by Google App Engine
This is Rietveld 408576698