Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1413923015: [Chromoting] Fix telemetry error in remoting.It2MeActivity (Closed)

Created:
5 years, 1 month ago by kelvinp
Modified:
5 years, 1 month ago
Reviewers:
Jamie, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org, anandc
Base URL:
https://chromium.googlesource.com/chromium/src.git@Rename_error_field
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Fix telemetry error in remoting.It2MeActivity 1. Excludes the access code entry time from the session duration. 2. Reports cancellation/error to the telemetry service if the main promise in It2meActivity.start() rejects. 3. Disposes DesktopRemotingActivity if the session fails to connect. BUG=549658 Committed: https://crrev.com/cb61f37e5f706260e86e7e95e91596408cf78e9c Cr-Commit-Position: refs/heads/master@{#358874}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M remoting/webapp/crd/js/it2me_activity.js View 1 1 chunk +22 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
kelvinp
Jamie, PTAL Adding Gary as Jamie will be OOO soon.
5 years, 1 month ago (2015-11-07 05:18:45 UTC) #4
Jamie
lgtm https://codereview.chromium.org/1413923015/diff/20001/remoting/webapp/crd/js/it2me_activity.js File remoting/webapp/crd/js/it2me_activity.js (right): https://codereview.chromium.org/1413923015/diff/20001/remoting/webapp/crd/js/it2me_activity.js#newcode54 remoting/webapp/crd/js/it2me_activity.js:54: base.dispose(this.desktopActivity_); Do you ever expect desktopActivity to be ...
5 years, 1 month ago (2015-11-09 18:16:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413923015/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413923015/40001
5 years, 1 month ago (2015-11-10 18:44:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-10 19:27:01 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 19:28:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb61f37e5f706260e86e7e95e91596408cf78e9c
Cr-Commit-Position: refs/heads/master@{#358874}

Powered by Google App Engine
This is Rietveld 408576698