Always give class literals a block scope

Always give class literals a block scope

Class methods always have the class scope on their scope chain in order
to implement strong mode checks. Previously, that scope wasn't attached
to the ClassLiteral for anonymous classes (since the scope contained
no bindings).

This patch simply puts that same scope on the ClassLiteral, anonymous
or not, which simplifies other code that needs to reason about the scope
of a class and its methods.

Committed: https://crrev.com/cf13dda1ba25e8293ea143f33c6c5f6233a39c86
Cr-Commit-Position: refs/heads/master@{#31371}

[adamk, 2015-10-19 09:47:36]

adamk@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[adamk, 2015-10-19 09:50:44]

The code that makes use of this empty scope is in
Scope::ClassVariableForMethod():

https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/scopes.cc&l...

[Michael Starzinger, 2015-10-19 10:36:44]

Description was changed from

==========
Always give class literals a block scope

Class methods always have the class scope on their scope chain in order
to implement strong mode checks. Previously, that scope wasn't attached
to the ClassLiteral for anonymous classes (since the scope contaioned
no bindings).

This patch simply puts that same scope on the ClassLiteral, anonymous
or not, which simplifies other code that needs to reason about the scope
of a class and its methods.
==========

to

==========
Always give class literals a block scope

Class methods always have the class scope on their scope chain in order
to implement strong mode checks. Previously, that scope wasn't attached
to the ClassLiteral for anonymous classes (since the scope contained
no bindings).

This patch simply puts that same scope on the ClassLiteral, anonymous
or not, which simplifies other code that needs to reason about the scope
of a class and its methods.
==========

[Michael Starzinger, 2015-10-19 10:40:41]

LGTM.

[adamk, 2015-10-19 10:44:57]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-10-19 10:45:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413903002/20001

[commit-bot: I haz the power, 2015-10-19 11:38:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-19 11:38:40]

Patchset 2 (id:??) landed as
https://crrev.com/cf13dda1ba25e8293ea143f33c6c5f6233a39c86
Cr-Commit-Position: refs/heads/master@{#31371}

[Michael Achenbach, 2015-10-19 12:16:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1416583002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks vector stores:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%2....

[adamk, 2015-10-19 13:45:07]

Sorry for the breakage, this was re-uploaded with a fix in
https://codereview.chromium.org/1418433002/