Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 14139022: Tab audio indicator: Tweak animation (Closed)

Created:
7 years, 8 months ago by sail
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Tab audio indicator: Tweak animation Two small tweaks to the audio indicator: - change the equalizer levels to look better with fewer bars - make animation slightly faster 300 ms per frame to 250 ms per frame. This doesn't noticeably increase CPU usage on my machine. Also fixed a small bug where the indicator would be drawn incorrectly when an equalizer level was 0. BUG=3541 TEST=Played a youtube video. Verified that the audio indicator in the favicon was updated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194657

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/ui/tabs/tab_audio_indicator.cc View 1 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sail
7 years, 8 months ago (2013-04-16 21:02:18 UTC) #1
Nico
lgtm
7 years, 8 months ago (2013-04-16 23:33:19 UTC) #2
sail
7 years, 8 months ago (2013-04-17 19:42:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r194657.

Powered by Google App Engine
This is Rietveld 408576698