content/common/view_messages.h - Issue 14139013: Hide location bar on Javascript-initiated scroll.

Unified Diff: content/common/view_messages.h

Issue 14139013: Hide location bar on Javascript-initiated scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge after sync. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index d83b077dde887ed785df5bfd98f976ae48a34c5e..140a6c6bbc830297ef6f931a85baee12588df8a1 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -1366,6 +1366,9 @@ IPC_MESSAGE_ROUTED3(ViewMsg_UpdateTopControlsState,

bool /* enable_showing */,

bool /* animate */)

+// Tells the renderer to show or hide the top controls.

+IPC_MESSAGE_ROUTED1(ViewMsg_ShowTopControls, bool /* show */)

jam 2013/04/17 16:24:59 i'm not familiar what top controls are? is this a

Michael van Ouwerkerk 2013/04/18 18:11:38 It's the piece of browser ui at the top that inclu

jam 2013/04/19 18:30:22 I see. it seems like a layering violation that thi

IPC_MESSAGE_ROUTED0(ViewMsg_ShowImeIfNeeded)

#elif defined(OS_MACOSX)

@@ -1508,6 +1511,11 @@ IPC_MESSAGE_ROUTED0(ViewHostMsg_UpdateScreenRects_ACK)

IPC_MESSAGE_ROUTED1(ViewHostMsg_RequestMove,

gfx::Rect /* position */)

+// Sent by the renderer process to notify the browser that the web page has

+// programmatically scrolled.

+IPC_MESSAGE_ROUTED1(ViewHostMsg_DidProgrammaticallyScroll,

+ gfx::Point /* scroll point */)

jam 2013/04/17 16:24:59 nit: convention is that the comment holds the para

Michael van Ouwerkerk 2013/04/18 18:11:38 Done.

// Notifies the browser that a frame in the view has changed. This message

// has a lot of parameters and is packed/unpacked by functions defined in

// render_messages.h.