Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 14139013: Hide location bar on Javascript-initiated scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge after sync. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 484e1fc587e6340e2690e10f24cae8ece87df5dc..91b2123b27d714b5a101d2bff149d04145eb9891 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -915,6 +915,8 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_BEGIN_MESSAGE_MAP_EX(RenderViewHostImpl, msg, msg_is_ok)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowView, OnShowView)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowWidget, OnShowWidget)
+ IPC_MESSAGE_HANDLER(ViewHostMsg_DidProgrammaticallyScroll,
+ OnDidProgrammaticallyScroll)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowFullscreenWidget,
OnShowFullscreenWidget)
IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunModal, OnRunModal)
@@ -1075,6 +1077,11 @@ void RenderViewHostImpl::OnShowWidget(int route_id,
Send(new ViewMsg_Move_ACK(route_id));
}
+void RenderViewHostImpl::OnDidProgrammaticallyScroll(
+ const gfx::Point& scroll_point) {
+ delegate_->DidProgrammaticallyScroll(scroll_point);
jam 2013/04/17 16:24:59 do not dispatch a message in RVHImpl just to call
Michael van Ouwerkerk 2013/04/18 18:11:38 Oh nice! Done.
+}
+
void RenderViewHostImpl::OnShowFullscreenWidget(int route_id) {
if (!is_swapped_out_)
delegate_->ShowCreatedFullscreenWidget(route_id);

Powered by Google App Engine
This is Rietveld 408576698