content/test/gpu/gpu_tests/cloud_storage_test_base.py - Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/cloud_storage_test_base.py

Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kbr's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/gpu/gpu_tests/cloud_storage_test_base.py

diff --git a/content/test/gpu/gpu_tests/cloud_storage_test_base.py b/content/test/gpu/gpu_tests/cloud_storage_test_base.py

index 0330c4bb82f08e02069b8a88c46d732ba6d8e4b1..d218d3ff9512b8edc615503ac6dc78ea23d400f2 100644

--- a/content/test/gpu/gpu_tests/cloud_storage_test_base.py

+++ b/content/test/gpu/gpu_tests/cloud_storage_test_base.py

@@ -14,7 +14,7 @@ from telemetry.page import page_test

from telemetry.util import image_util

from telemetry.util import rgba_color

-import gpu_test_base

+from gpu_tests import gpu_test_base

test_data_dir = os.path.abspath(os.path.join(

os.path.dirname(__file__), '..', '..', 'data', 'gpu'))

@@ -192,7 +192,7 @@ class ValidatorBase(gpu_test_base.ValidatorBase):

supplied), and diff image (if reference image was supplied) to cloud

storage. This subsumes the functionality of the

archive_gpu_pixel_test_results.py script."""

- machine_name = re.sub('\W+', '_', self.options.test_machine_name)

+ machine_name = re.sub(r'\W+', '_', self.options.test_machine_name)

upload_dir = '%s_%s_telemetry' % (self.options.build_revision, machine_name)

base_bucket = '%s/runs/%s' % (error_image_cloud_storage_bucket, upload_dir)

image_name_with_revision = '%s_%s.png' % (

« no previous file with comments | « content/test/gpu/gpu_project_config.py ('k') | content/test/gpu/gpu_tests/context_lost.py » ('j') | no next file with comments »