Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Side by Side Diff: content/test/gpu/gpu_tests/cloud_storage_test_base.py

Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address kbr's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/gpu/gpu_project_config.py ('k') | content/test/gpu/gpu_tests/context_lost.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Base classes for a test and validator which upload results 5 """Base classes for a test and validator which upload results
6 (reference images, error images) to cloud storage.""" 6 (reference images, error images) to cloud storage."""
7 7
8 import os 8 import os
9 import re 9 import re
10 import tempfile 10 import tempfile
11 11
12 from catapult_base import cloud_storage 12 from catapult_base import cloud_storage
13 from telemetry.page import page_test 13 from telemetry.page import page_test
14 from telemetry.util import image_util 14 from telemetry.util import image_util
15 from telemetry.util import rgba_color 15 from telemetry.util import rgba_color
16 16
17 import gpu_test_base 17 from gpu_tests import gpu_test_base
18 18
19 test_data_dir = os.path.abspath(os.path.join( 19 test_data_dir = os.path.abspath(os.path.join(
20 os.path.dirname(__file__), '..', '..', 'data', 'gpu')) 20 os.path.dirname(__file__), '..', '..', 'data', 'gpu'))
21 21
22 default_generated_data_dir = os.path.join(test_data_dir, 'generated') 22 default_generated_data_dir = os.path.join(test_data_dir, 'generated')
23 23
24 error_image_cloud_storage_bucket = 'chromium-browser-gpu-tests' 24 error_image_cloud_storage_bucket = 'chromium-browser-gpu-tests'
25 25
26 def _CompareScreenshotSamples(screenshot, expectations, device_pixel_ratio): 26 def _CompareScreenshotSamples(screenshot, expectations, device_pixel_ratio):
27 for expectation in expectations: 27 for expectation in expectations:
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 cloud_storage.Get(self.options.refimg_cloud_storage_bucket, 185 cloud_storage.Get(self.options.refimg_cloud_storage_bucket,
186 self._FormatReferenceImageName(img_name, page, tab), 186 self._FormatReferenceImageName(img_name, page, tab),
187 temp_file) 187 temp_file)
188 return image_util.FromPngFile(temp_file) 188 return image_util.FromPngFile(temp_file)
189 189
190 def _UploadErrorImagesToCloudStorage(self, image_name, screenshot, ref_img): 190 def _UploadErrorImagesToCloudStorage(self, image_name, screenshot, ref_img):
191 """For a failing run, uploads the failing image, reference image (if 191 """For a failing run, uploads the failing image, reference image (if
192 supplied), and diff image (if reference image was supplied) to cloud 192 supplied), and diff image (if reference image was supplied) to cloud
193 storage. This subsumes the functionality of the 193 storage. This subsumes the functionality of the
194 archive_gpu_pixel_test_results.py script.""" 194 archive_gpu_pixel_test_results.py script."""
195 machine_name = re.sub('\W+', '_', self.options.test_machine_name) 195 machine_name = re.sub(r'\W+', '_', self.options.test_machine_name)
196 upload_dir = '%s_%s_telemetry' % (self.options.build_revision, machine_name) 196 upload_dir = '%s_%s_telemetry' % (self.options.build_revision, machine_name)
197 base_bucket = '%s/runs/%s' % (error_image_cloud_storage_bucket, upload_dir) 197 base_bucket = '%s/runs/%s' % (error_image_cloud_storage_bucket, upload_dir)
198 image_name_with_revision = '%s_%s.png' % ( 198 image_name_with_revision = '%s_%s.png' % (
199 image_name, self.options.build_revision) 199 image_name, self.options.build_revision)
200 self._UploadBitmapToCloudStorage( 200 self._UploadBitmapToCloudStorage(
201 base_bucket + '/gen', image_name_with_revision, screenshot, 201 base_bucket + '/gen', image_name_with_revision, screenshot,
202 public=True) 202 public=True)
203 if ref_img is not None: 203 if ref_img is not None:
204 self._UploadBitmapToCloudStorage( 204 self._UploadBitmapToCloudStorage(
205 base_bucket + '/ref', image_name_with_revision, ref_img, public=True) 205 base_bucket + '/ref', image_name_with_revision, ref_img, public=True)
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 default='') 258 default='')
259 group.add_option('--test-machine-name', 259 group.add_option('--test-machine-name',
260 help='Name of the test machine. Specifying this argument causes this ' 260 help='Name of the test machine. Specifying this argument causes this '
261 'script to upload failure images and diffs to cloud storage directly, ' 261 'script to upload failure images and diffs to cloud storage directly, '
262 'instead of relying on the archive_gpu_pixel_test_results.py script.', 262 'instead of relying on the archive_gpu_pixel_test_results.py script.',
263 default='') 263 default='')
264 group.add_option('--generated-dir', 264 group.add_option('--generated-dir',
265 help='Overrides the default on-disk location for generated test images ' 265 help='Overrides the default on-disk location for generated test images '
266 '(only used for local testing without a cloud storage account)', 266 '(only used for local testing without a cloud storage account)',
267 default=default_generated_data_dir) 267 default=default_generated_data_dir)
OLDNEW
« no previous file with comments | « content/test/gpu/gpu_project_config.py ('k') | content/test/gpu/gpu_tests/context_lost.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698