content/test/gpu/gpu_tests/webgl_conformance_expectations.py - Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/gpu/gpu_tests/test_expectations_unittest.py ('K') | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/webgl_conformance_expectations.py

diff --git a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

index e9f6dff1a123f48a038fa872a4b49bfa411fa331..02b142088725d0745f10661459bb0b288c223bed 100644

--- a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

+++ b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

@@ -3,14 +3,14 @@

# found in the LICENSE file.

import os

-from gpu_test_expectations import GpuTestExpectations

+from gpu_tests.gpu_test_expectations import GpuTestExpectations

# See the GpuTestExpectations class for documentation.

class WebGLConformanceExpectations(GpuTestExpectations):

def __init__(self, conformance_path):

self.conformance_path = conformance_path

- super(WebGLConformanceExpectations, self).__init__()

+ GpuTestExpectations.__init__(self)

Ken Russell (switch to Gerrit) 2015/10/21 22:12:08 I'd rather use the super() syntax to avoid explici

Corentin Wallez 2015/10/21 23:07:25 Done.

def Fail(self, pattern, condition=None, bug=None):

self.CheckPatternIsValid(pattern)