content/test/gpu/gpu_tests/test_expectations_unittest.py - Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/test_expectations_unittest.py

Issue 1413883003: Add a presubmit script and pylintrc for content/test/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/gpu/gpu_tests/gpu_test_base_unittest.py ('K') | « content/test/gpu/gpu_tests/test_expectations.py ('k') | content/test/gpu/gpu_tests/trace_test.py » ('j') | content/test/gpu/gpu_tests/webgl_conformance_expectations.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/test_expectations_unittest.py

diff --git a/content/test/gpu/gpu_tests/test_expectations_unittest.py b/content/test/gpu/gpu_tests/test_expectations_unittest.py

index 6faf0dcc04182a9b6363c3d7cc83e89b204941bc..ad5acda558938e55b90882fa34cbe367259a5e7c 100644

--- a/content/test/gpu/gpu_tests/test_expectations_unittest.py

+++ b/content/test/gpu/gpu_tests/test_expectations_unittest.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

import unittest

-import test_expectations

+from gpu_tests import test_expectations

from telemetry.page import page as page_module

from telemetry.story import story_set

@@ -29,9 +29,6 @@ class StubBrowser(object):

def supports_system_info(self):

return False

- def GetSystemInfo(self):

- return self.system_info

Ken Russell (switch to Gerrit) 2015/10/21 22:12:08 Good catch.

Corentin Wallez 2015/10/21 23:07:25 Acknowledged.

class SampleExpectationSubclass(test_expectations.Expectation):

def __init__(self, expectation, pattern, conditions=None, bug=None):