Add a presubmit script and pylintrc for content/test/gpu

content/test/gpu/gpu_tests/cloud_storage_test_base.py

Index: content/test/gpu/gpu_tests/cloud_storage_test_base.py
diff --git a/content/test/gpu/gpu_tests/cloud_storage_test_base.py b/content/test/gpu/gpu_tests/cloud_storage_test_base.py
index 0330c4bb82f08e02069b8a88c46d732ba6d8e4b1..dc08d2472319e14929c1400bc009be610f1293bf 100644
--- a/content/test/gpu/gpu_tests/cloud_storage_test_base.py
+++ b/content/test/gpu/gpu_tests/cloud_storage_test_base.py
@@ -14,7 +14,7 @@ from telemetry.page import page_test
 from telemetry.util import image_util
 from telemetry.util import rgba_color
 
-import gpu_test_base
+from gpu_tests import gpu_test_base
 
 test_data_dir = os.path.abspath(os.path.join(
     os.path.dirname(__file__), '..', '..', 'data', 'gpu'))
@@ -56,7 +56,7 @@ def _CompareScreenshotSamples(screenshot, expectations, device_pixel_ratio):
 
 class ValidatorBase(gpu_test_base.ValidatorBase):
   def __init__(self):
-    super(ValidatorBase, self).__init__()
+    gpu_test_base.ValidatorBase.__init__(self)

[Ken Russell (switch to Gerrit), 2015/10/21 22:12:08]

It's undesirable to name the superclass explicitly. Can you find another way to
avoid the presubmit warning? Maybe name this one CloudStorageValidatorBase?

[Corentin Wallez, 2015/10/21 23:07:25]

I was having a pylint error related to using super() with an old-style class.
Deleting all the .pyc as the telemetry guys suggested seems to have removed that
warning so I removed this change

Done

     # Parameters for cloud storage reference images.
     self.vendor_id = None
     self.device_id = None
@@ -192,7 +192,7 @@ class ValidatorBase(gpu_test_base.ValidatorBase):
     supplied), and diff image (if reference image was supplied) to cloud
     storage. This subsumes the functionality of the
     archive_gpu_pixel_test_results.py script."""
-    machine_name = re.sub('\W+', '_', self.options.test_machine_name)
+    machine_name = re.sub(r'\W+', '_', self.options.test_machine_name)
     upload_dir = '%s_%s_telemetry' % (self.options.build_revision, machine_name)
     base_bucket = '%s/runs/%s' % (error_image_cloud_storage_bucket, upload_dir)
     image_name_with_revision = '%s_%s.png' % (