Add a presubmit script and pylintrc for content/test/gpu

content/test/gpu/gpu_tests/cloud_storage_test_base.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Base classes for a test and validator which upload results
 (reference images, error images) to cloud storage."""
 
 import os
 import re
 import tempfile
 
 from catapult_base import cloud_storage
 from telemetry.page import page_test
 from telemetry.util import image_util
 from telemetry.util import rgba_color
 
-import gpu_test_base
+from gpu_tests import gpu_test_base
 
 test_data_dir = os.path.abspath(os.path.join(
     os.path.dirname(__file__), '..', '..', 'data', 'gpu'))
 
 default_generated_data_dir = os.path.join(test_data_dir, 'generated')
 
 error_image_cloud_storage_bucket = 'chromium-browser-gpu-tests'
 
 def _CompareScreenshotSamples(screenshot, expectations, device_pixel_ratio):
   for expectation in expectations:
@@ skipping 21 matching lines @@
         if not actual_color.IsEqual(expected_color, expectation["tolerance"]):
           raise page_test.Failure('Expected pixel at ' + str(location) +
               ' to be ' +
               str(expectation["color"]) + " but got [" +
               str(actual_color.r) + ", " +
               str(actual_color.g) + ", " +
               str(actual_color.b) + "]")
 
 class ValidatorBase(gpu_test_base.ValidatorBase):
   def __init__(self):
-    super(ValidatorBase, self).__init__()
+    gpu_test_base.ValidatorBase.__init__(self)

[Ken Russell (switch to Gerrit), 2015/10/21 22:12:08]

It's undesirable to name the superclass explicitly. Can you find another way to
avoid the presubmit warning? Maybe name this one CloudStorageValidatorBase?

[Corentin Wallez, 2015/10/21 23:07:25]

I was having a pylint error related to using super() with an old-style class.
Deleting all the .pyc as the telemetry guys suggested seems to have removed that
warning so I removed this change

Done

     # Parameters for cloud storage reference images.
     self.vendor_id = None
     self.device_id = None
     self.vendor_string = None
     self.device_string = None
     self.msaa = False
 
   ###
   ### Routines working with the local disk (only used for local
   ### testing without a cloud storage account -- the bots do not use
@@ skipping 115 matching lines @@
     cloud_storage.Get(self.options.refimg_cloud_storage_bucket,
                       self._FormatReferenceImageName(img_name, page, tab),
                       temp_file)
     return image_util.FromPngFile(temp_file)
 
   def _UploadErrorImagesToCloudStorage(self, image_name, screenshot, ref_img):
     """For a failing run, uploads the failing image, reference image (if
     supplied), and diff image (if reference image was supplied) to cloud
     storage. This subsumes the functionality of the
     archive_gpu_pixel_test_results.py script."""
-    machine_name = re.sub('\W+', '_', self.options.test_machine_name)
+    machine_name = re.sub(r'\W+', '_', self.options.test_machine_name)
     upload_dir = '%s_%s_telemetry' % (self.options.build_revision, machine_name)
     base_bucket = '%s/runs/%s' % (error_image_cloud_storage_bucket, upload_dir)
     image_name_with_revision = '%s_%s.png' % (
       image_name, self.options.build_revision)
     self._UploadBitmapToCloudStorage(
       base_bucket + '/gen', image_name_with_revision, screenshot,
       public=True)
     if ref_img is not None:
       self._UploadBitmapToCloudStorage(
         base_bucket + '/ref', image_name_with_revision, ref_img, public=True)
@@ skipping 52 matching lines @@
         default='')
     group.add_option('--test-machine-name',
         help='Name of the test machine. Specifying this argument causes this '
         'script to upload failure images and diffs to cloud storage directly, '
         'instead of relying on the archive_gpu_pixel_test_results.py script.',
         default='')
     group.add_option('--generated-dir',
         help='Overrides the default on-disk location for generated test images '
         '(only used for local testing without a cloud storage account)',
         default=default_generated_data_dir)