[Interpreter] Add switch support.

[Interpreter] Add switch support.

Adds support for switch statments to the interpreter.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/40f8605ff987031b2dc104c71f5f89754281cd29
Cr-Commit-Position: refs/heads/master@{#31687}

[rmcilroy, 2015-10-29 17:47:23]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2015-10-29 17:48:31]

rmcilroy@chromium.org changed reviewers:
+ mythria@chromium.org, oth@chromium.org

[rmcilroy, 2015-10-29 17:48:32]

Orion / Mythri: please take a look, thanks.

Michi: FYI (any comments welcome)

[rmcilroy, 2015-10-29 17:48:37]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 17:48:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415093006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415093006/20001

[commit-bot: I haz the power, 2015-10-29 18:19:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 18:19:54]

Dry run: This issue passed the CQ dry run.

[oth, 2015-10-30 10:10:04]

lgtm. Very nice!

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:108: class
BytecodeGenerator::ControlScopeForSwitch
Nit - suggest putting ControlScopeForSwitch after ControlScopeForIteration.

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.h (right):

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.h:33: class ControlScopeForSwitch;
Nit - can we have alpha sorting here. ControlScopeFor...

[rmcilroy, 2015-10-30 11:47:00]

Also added some nested switch tests.

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:108: class
BytecodeGenerator::ControlScopeForSwitch
On 2015/10/30 10:10:04, oth wrote:
> Nit - suggest putting ControlScopeForSwitch after ControlScopeForIteration.

Done.

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.h (right):

https://codereview.chromium.org/1415093006/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.h:33: class ControlScopeForSwitch;
On 2015/10/30 10:10:04, oth wrote:
> Nit - can we have alpha sorting here. ControlScopeFor...

Done.

[rmcilroy, 2015-10-30 11:48:38]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 11:48:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415093006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415093006/40001

[commit-bot: I haz the power, 2015-10-30 11:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 11:49:32]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9623)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/10238)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11211)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11335)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7239)

[rmcilroy, 2015-10-30 11:53:25]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 11:53:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415093006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415093006/60001

[commit-bot: I haz the power, 2015-10-30 12:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 12:24:50]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-10-30 12:34:39]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-30 12:34:39]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1415093006/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2015-10-30 12:34:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415093006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415093006/60001

[commit-bot: I haz the power, 2015-10-30 12:55:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-30 12:55:36]

Patchset 3 (id:??) landed as
https://crrev.com/40f8605ff987031b2dc104c71f5f89754281cd29
Cr-Commit-Position: refs/heads/master@{#31687}