chrome/common/extensions/api/developer_private.idl - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/developer_private.idl

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits, treat hosted apps as extensions, no test flakiness Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/process_manager_browsertest.cc ('K') | « chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc ('k') | chrome/test/data/extensions/api_test/messaging/connect_nobackground/contentscript.js » ('j') | extensions/browser/extension_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/developer_private.idl

diff --git a/chrome/common/extensions/api/developer_private.idl b/chrome/common/extensions/api/developer_private.idl

index 15e7dc00d437c8aa37e1db26ed5c546e6c048e37..471886b4f8fa3692b59c299faf84411fcfb9da67 100644

--- a/chrome/common/extensions/api/developer_private.idl

+++ b/chrome/common/extensions/api/developer_private.idl

@@ -64,6 +64,7 @@ namespace developerPrivate {

BACKGROUND_CONTENTS,

EXTENSION_BACKGROUND_PAGE,

EXTENSION_DIALOG,

+ EXTENSION_OPTIONS,

Devlin 2015/12/01 00:58:20 IMO, we already have too many view types. But I d

robwu 2015/12/01 17:19:57 Done (s/EXTENSION_OPTIONS/EXTENSION_GUEST/). Shoul

EXTENSION_POPUP,

LAUNCHER_PAGE,

PANEL,