chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc - Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

Issue 1413853005: Track all extension frames in ProcessManager, inspect extensionoptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits, treat hosted apps as extensions, no test flakiness Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/process_manager_browsertest.cc ('K') | « chrome/browser/extensions/process_manager_browsertest.cc ('k') | chrome/common/extensions/api/developer_private.idl » ('j') | chrome/common/extensions/api/developer_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

index 99b336eff3716193a085a01090824468a8af8507..a9099abf500996b25589c736e84fe1e48d122ce2 100644

--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

@@ -423,6 +423,7 @@ void ChromeSpeechRecognitionManagerDelegate::CheckRenderViewType(

view_type == extensions::VIEW_TYPE_APP_WINDOW ||

view_type == extensions::VIEW_TYPE_LAUNCHER_PAGE ||

view_type == extensions::VIEW_TYPE_VIRTUAL_KEYBOARD ||

+ view_type == extensions::VIEW_TYPE_EXTENSION_POPUP ||

view_type == extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {

// If it is a tab, we can check for permission. For apps, this means

// manifest would be checked for permission.