Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1413813006: Revert of Add TransportSession interface to prepare for WebRTC-based transport. (Closed)

Created:
5 years, 1 month ago by Georges Khalil
Modified:
5 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add TransportSession interface to prepare for WebRTC-based transport. (patchset #4 id:60001 of https://codereview.chromium.org/1420273002/ ) Reason for revert: Broke android build. Original issue's description: > Add TransportSession interface to prepare for WebRTC-based transport. > > Previosly JingleSession was responsible to establishing connection > with the peer and managing list of channels. Now the new > IceTransportSession class (that implements TransportSession interface) > is responsible for managing list of channels and so it will be possible > to add support for WebRTC-based transport by adding another > TransportSession implementation. > > There are no functional changes in this CL. > > BUG=547158 > > Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b > Cr-Commit-Position: refs/heads/master@{#356588} TBR=jamiewalch@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=547158 Committed: https://crrev.com/bedd6b96ef6b16a53432008acc865bfd82fb3e98 Cr-Commit-Position: refs/heads/master@{#356595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -734 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M remoting/protocol/channel_multiplexer_unittest.cc View 5 chunks +20 lines, -29 lines 0 comments Download
M remoting/protocol/client_video_dispatcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/protocol/datagram_channel_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/fake_session.h View 2 chunks +7 lines, -22 lines 0 comments Download
M remoting/protocol/fake_session.cc View 2 chunks +8 lines, -31 lines 0 comments Download
D remoting/protocol/ice_transport_factory.h View 1 chunk +0 lines, -46 lines 0 comments Download
D remoting/protocol/ice_transport_factory.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/protocol/ice_transport_session.h View 1 chunk +0 lines, -95 lines 0 comments Download
D remoting/protocol/ice_transport_session.cc View 1 chunk +0 lines, -193 lines 0 comments Download
M remoting/protocol/jingle_messages.h View 3 chunks +21 lines, -33 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 8 chunks +53 lines, -55 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M remoting/protocol/jingle_session.h View 7 chunks +48 lines, -11 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 13 chunks +163 lines, -38 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 8 chunks +28 lines, -44 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 3 chunks +13 lines, -5 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/session.h View 2 chunks +9 lines, -6 lines 0 comments Download
M remoting/protocol/transport.h View 5 chunks +18 lines, -57 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Georges Khalil
Created Revert of Add TransportSession interface to prepare for WebRTC-based transport.
5 years, 1 month ago (2015-10-28 18:47:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413813006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413813006/1
5 years, 1 month ago (2015-10-28 18:48:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 18:50:00 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 18:51:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bedd6b96ef6b16a53432008acc865bfd82fb3e98
Cr-Commit-Position: refs/heads/master@{#356595}

Powered by Google App Engine
This is Rietveld 408576698