Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413763002: path ops: fix conic weight and partial coincidence (Closed)

Created:
5 years, 2 months ago by caryclark
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

The remaining 1m skp bugs are asserts that can be harmlessly suppressed and bugs around conics. The conic calculation for a subdivided w was just wrong. Also added debugging to template intersection to initialize reused structures and dump additional data. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af

Patch Set 1 #

Patch Set 2 : wip; conics fail to detect coincidence #

Patch Set 3 : fix skp-found conic coincidence #

Patch Set 4 : cleanup #

Patch Set 5 : remove samplecode changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1037 lines, -342 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 1 2 3 2 chunks +28 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsQuad.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 2 9 chunks +61 lines, -11 lines 0 comments Download
M src/pathops/SkPathOpsWinding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpTest.cpp View 2 chunks +661 lines, -3 lines 0 comments Download
M tests/PathOpsTSectDebug.h View 1 2 2 chunks +14 lines, -4 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 2 chunks +19 lines, -4 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 3 chunks +236 lines, -304 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413763002/80001
5 years, 2 months ago (2015-10-20 20:03:22 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 20:18:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413763002/80001
5 years, 2 months ago (2015-10-20 20:41:50 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af
5 years, 2 months ago (2015-10-20 20:42:28 UTC) #8
caryclark
5 years, 2 months ago (2015-10-21 11:02:30 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1408923003/ by caryclark@google.com.

The reason for reverting is: path ops change breaks svg clipping layout tests --
conic is now more accurate, changing edge of circle in clip

These need to be rebaselined

svg/clip-path/clip-path-child-clipped.svg
svg/clip-path/clip-path-nonzero.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-nonzero-evenodd.svg.

Powered by Google App Engine
This is Rietveld 408576698