Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1413733004: Remove FXJS_GetRuntime (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FXJS_GetRuntime Its pointless to have a function that gets the isolate given a v8::object, since v8 gives us that directly. Also remove some CreationContext() calls, since they are only used to get the isolate, and we can do so directly. R=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/93f191bb011508a8d4e66746135e8ba8e9583870

Patch Set 1 #

Patch Set 2 : Also remove CreationContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 5 chunks +5 lines, -6 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Sepez
Jochen, please review.
5 years, 1 month ago (2015-11-06 00:12:29 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-06 05:45:47 UTC) #6
Tom Sepez
5 years, 1 month ago (2015-11-06 16:19:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
93f191bb011508a8d4e66746135e8ba8e9583870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698