fpdfsdk/src/javascript/JS_Object.cpp - Issue 1413733004: Remove FXJS_GetRuntime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Object.cpp

Issue 1413733004: Remove FXJS_GetRuntime (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Also remove CreationContext Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Object.cpp

diff --git a/fpdfsdk/src/javascript/JS_Object.cpp b/fpdfsdk/src/javascript/JS_Object.cpp

index 0556c4ea476cdffe30647e0f27acf604987f3afd..8c067fd45454eab75f48fe631c8ae8c58e09fcf4 100644

--- a/fpdfsdk/src/javascript/JS_Object.cpp

+++ b/fpdfsdk/src/javascript/JS_Object.cpp

@@ -61,7 +61,7 @@ void DisposeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {

}

CJS_Object::CJS_Object(v8::Local<v8::Object> pObject) {

- m_pIsolate = pObject->CreationContext()->GetIsolate();

+ m_pIsolate = pObject->GetIsolate();

m_pV8Object.Reset(m_pIsolate, pObject);

}

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/global.cpp » ('j') | no next file with comments »