Remove DrawingMgr shims from GrContext

Remove DrawingMgr shims from GrContext

BUG=skia:4094
Committed: https://skia.googlesource.com/skia/+/77a2e52c7d5c77de73ecab5fec79072ee4460706

[robertphillips, 2015-10-16 17:23:20]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-10-16 17:26:19]

PTAL - The const cast in DrawingMgr::drawContext is a bit goofy but it limits
the power of the GrContext::drawingMgr call.

[bsalomon, 2015-10-16 17:54:53]

https://codereview.chromium.org/1413673002/diff/30001/gm/texdata.cpp
File gm/texdata.cpp (right):

https://codereview.chromium.org/1413673002/diff/30001/gm/texdata.cpp#newcode25
gm/texdata.cpp:25: SkAutoTUnref<GrDrawContext> drawContext(ctx ?
ctx->drawingMgr().drawContext(target)
really want to have to go through ->drawingMgr() for this one?

https://codereview.chromium.org/1413673002/diff/30001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1413673002/diff/30001/include/gpu/GrContext.h...
include/gpu/GrContext.h:361: class DrawingMgr {
Don't we want this to be private?

[robertphillips, 2015-10-16 19:00:34]

PTAL

[bsalomon, 2015-10-16 20:09:06]

lgtm

https://codereview.chromium.org/1413673002/diff/90001/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/1413673002/diff/90001/src/gpu/GrDrawingManage...
src/gpu/GrDrawingManager.h:17: // Currently the DrawingMgr creates a separate
GrTextContext for each
Might want to change Mgr here.

[robertphillips, 2015-10-17 14:14:05]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-17 14:14:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413673002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413673002/110001

[commit-bot: I haz the power, 2015-10-17 14:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-17 14:23:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-17 14:42:24]

https://codereview.chromium.org/1413673002/diff/90001/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/1413673002/diff/90001/src/gpu/GrDrawingManage...
src/gpu/GrDrawingManager.h:17: // Currently the DrawingMgr creates a separate
GrTextContext for each
On 2015/10/16 20:09:06, bsalomon wrote:
> Might want to change Mgr here.

Done.

[robertphillips, 2015-10-17 14:42:29]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-10-17 14:42:29]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1413673002/#ps110001
(title: "Fix names in comments")

[commit-bot: I haz the power, 2015-10-17 14:42:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413673002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413673002/110001

[commit-bot: I haz the power, 2015-10-17 14:43:31]

Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/77a2e52c7d5c77de73ecab5fec79072ee4460706