Do not fail checksum check before download

Do not fail checksum check before download

BUG=

Committed: https://crrev.com/82ea27a94a575ef1db382e70c05d38797c22ad6d
Cr-Commit-Position: refs/heads/master@{#355597}

[binji, 2015-10-19 18:51:40]

binji@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2015-10-19 18:51:41]

lgtm, thanks!

Please add your name/email to the native_client_sdk/src/AUTHORS.

[anatoly techtonik, 2015-10-19 18:58:53]

Done.

[anatoly techtonik, 2015-10-20 03:31:04]

The CQ bit was checked by techtonik@gmail.com

[anatoly techtonik, 2015-10-20 03:31:04]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1413663005/#ps20001
(title: "Adding myself to AUTHORS")

[commit-bot: I haz the power, 2015-10-20 03:31:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413663005/20001

[commit-bot: I haz the power, 2015-10-20 03:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 03:40:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[binji, 2015-10-22 18:24:01]

On 2015/10/20 at 03:40:01, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like you need to add your name to chromium/AUTHORS too

[anatoly techtonik, 2015-10-22 18:45:21]

I think the issue may be that I've added myself only after LGTM. But let's see.

[anatoly techtonik, 2015-10-22 18:45:24]

The CQ bit was checked by techtonik@gmail.com

[anatoly techtonik, 2015-10-22 18:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1413663005/#ps40001
(title: "Adding myself to chromium/AUTHORS")

[commit-bot: I haz the power, 2015-10-22 18:46:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413663005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413663005/40001

[Sam Clegg, 2015-10-22 18:55:02]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2015-10-22 18:55:02]

I realize it might be too late, but can you update the CL description to be a
little more descriptive?

Can you start the first line with "[NaCl SDK]"?

Presumably this change is fixing a problem with the NaCl SDK installation
process on windows?  (since the 'b' flag is meaningless on other platforms,
right?).

Any idea why we have not seen this problem before on any of our windows
machines?

[commit-bot: I haz the power, 2015-10-22 19:09:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-22 19:10:05]

Patchset 3 (id:??) landed as
https://crrev.com/82ea27a94a575ef1db382e70c05d38797c22ad6d
Cr-Commit-Position: refs/heads/master@{#355597}

[anatoly techtonik, 2015-10-22 19:17:02]

On 2015/10/22 18:55:02, Sam Clegg wrote:
> I realize it might be too late, but can you update the CL description to be a
> little more descriptive?
> 
> Can you start the first line with "[NaCl SDK]"?

I guess it is too late, but I will do this in future.

> Presumably this change is fixing a problem with the NaCl SDK installation
> process on windows?  (since the 'b' flag is meaningless on other platforms,
> right?).

Right. If you read the file in text mode, it produces different checksum.

> Any idea why we have not seen this problem before on any of our windows
> machines?

Because you have fast connections and don't mind redownloading cached files
every time.

[Sam Clegg, 2015-10-22 20:27:08]

On 2015/10/22 19:17:02, anatoly techtonik wrote:
> On 2015/10/22 18:55:02, Sam Clegg wrote:
> > I realize it might be too late, but can you update the CL description to be
a
> > little more descriptive?
> > 
> > Can you start the first line with "[NaCl SDK]"?
> 
> I guess it is too late, but I will do this in future.
> 
> > Presumably this change is fixing a problem with the NaCl SDK installation
> > process on windows?  (since the 'b' flag is meaningless on other platforms,
> > right?).
> 
> Right. If you read the file in text mode, it produces different checksum.
> 
> > Any idea why we have not seen this problem before on any of our windows
> > machines?
> 
> Because you have fast connections and don't mind redownloading cached files
> every time.

I see.  Assumed this function was being used to all verification, but it looks
like the download and verify is done in a different way.  Thanks for fixing
this.