Do not fail checksum check before download

native_client_sdk/src/build_tools/sdk_tools/command/update.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import hashlib
 import copy
 import logging
 import os
 import subprocess
 import sys
@@ skipping 56 matching lines @@
     filename = os.path.join(self.archive_cache, filename)
     if not os.path.exists(filename):
       logging.info('File does not exist: %s.' % filename)
       return False
     size = os.path.getsize(filename)
     if size != archive.size:
       logging.info('File size does not match (%d vs %d): %s.' % (size,
           archive.size, filename))
       return False
     sha1_hash = hashlib.sha1()
-    with open(filename) as f:
+    with open(filename, 'rb') as f:
       sha1_hash.update(f.read())
     if sha1_hash.hexdigest() != archive.GetChecksum():
       logging.info('File hash does not match: %s.' % filename)
       return False
     return True
 
   def BytesUsedInCache(self):
     """Determine number of bytes currently be in local archive cache."""
     total = 0
     for root, _, files in os.walk(self.archive_cache):
@@ skipping 292 matching lines @@
   return os.path.basename(path)
 
 
 def _ValidateArchive(archive, actual_sha1, actual_size):
   if actual_size != archive.size:
     raise Error('Size mismatch on "%s".  Expected %s but got %s bytes' % (
         archive.url, archive.size, actual_size))
   if actual_sha1 != archive.GetChecksum():
     raise Error('SHA1 checksum mismatch on "%s".  Expected %s but got %s' % (
         archive.url, archive.GetChecksum(), actual_sha1))