Consolidate some about flags code into FlagsState class.

Consolidate some about_flags code into FlagsState class.

This moves the previously file-global variables g_entries and
g_num_entries into the FlagsState class as member variables and
renames them. Also changes a few free-standing functions that use
those variables to be member functions on the FlagsState class.

This refactoring paves way for extracting the FlagsState class into its
own file that can be more easily componentized, which can be done in
a later CL. My other planned change is to expand the functionality in
this class to integrate with base::FeatureList and this refactoring makes
the CL for that easier to review.

BUG=544158
Committed: https://crrev.com/91931d560ef0b15847f12613d50ac97aa1877056
Cr-Commit-Position: refs/heads/master@{#354544}

[Alexei Svitkine (slow), 2015-10-16 15:50:29]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2015-10-16 15:51:58]

asvitkine@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-10-16 16:36:12]

this change lgtm

For the linked BUG=: How will this work if a FeatureList flag is passed as a
--flag instead of being enabled on about:flags?

[Alexei Svitkine (slow), 2015-10-16 16:37:57]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-10-16 16:38:29]

The idea is not to have dedicated --enable-foo and --enable-bar flags for
base::FeatureList entries, since they have a standard mechanism
(--enable-feature=Foo).

On Fri, Oct 16, 2015 at 12:36 PM, <thakis@chromium.org> wrote:

> this change lgtm
>
> For the linked BUG=: How will this work if a FeatureList flag is passed as
> a
> --flag instead of being enabled on about:flags?
>
> https://codereview.chromium.org/1413633003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-10-16 16:38:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413633003/20001

[Nico, 2015-10-16 16:40:05]

makes sense, thanks

[commit-bot: I haz the power, 2015-10-16 17:55:54]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-10-16 17:56:50]

Patchset 1 (id:??) landed as
https://crrev.com/91931d560ef0b15847f12613d50ac97aa1877056
Cr-Commit-Position: refs/heads/master@{#354544}