Issue 1413593008: DevTools: straw man adaptable implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413593008: DevTools: straw man adaptable implementation. (Closed)

Created:
5 years, 1 month ago by pfeldman

Modified:
5 years ago

Reviewers:
dgozman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: straw man adaptable implementation. BUG=459685

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -4 lines)			Patch
M	third_party/WebKit/Source/devtools/front_end/Runtime.js	View	2 chunks	+34 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js	View	2 chunks	+22 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/module.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js	View	4 chunks	+21 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kdzwinel

5 years, 1 month ago (2015-11-03 23:01:36 UTC) #3

On 2015/10/30 at 00:04:55, pfeldman wrote:
> 

1) I've noticed that, after applying this patch, "Reveal in Elements Panel"
shows up twice in the context menu when a DOM node is right clicked in the
console ( http://i.imgur.com/Ppj0N5M.png ). It looks like
ElementsPanel.appendApplicableItems is called twice - once with object being a
DOMNode and then second time with object being a RemoteObjectImpl.

2) In our attempt to fix that issue ( https://codereview.chromium.org/1409693007
) we referenced "Scroll into view" implementation
(ElementsTreeElement._scrollIntoView) as it also does a DOMNode ->
RemoteObjectImpl conversion. Can ElementsTreeElement._scrollIntoView benefit
form changes proposed in this patch? Should this._node.resolveToObject be
replaced with a use of Runtime.adapt? Just a thought, I might be absolutely
wrong here.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages