Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409693007: DevTools fixes #459685. Right Clicking on an element should show "Store as Global Variable". (Closed)

Created:
5 years, 2 months ago by kdzwinel
Modified:
5 years, 1 month ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools fixes #459685. Right Clicking on an element should show "Store as Global Variable". BUG=459685

Patch Set 1 #

Total comments: 1

Patch Set 2 : Making context menu message a bit more descriptive. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M AUTHORS View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +24 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
kdzwinel
Please take a look. Thank you! Konrad & Jason
5 years, 1 month ago (2015-10-26 18:58:12 UTC) #2
paulirish
https://codereview.chromium.org/1409693007/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/1409693007/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode990 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:990: contextMenu.appendItem(WebInspector.UIString.capitalize("Store as ^global ^variable"), resolveNodeAndCall.bind(null, domNode, this._saveToTempVariable.bind(this))); Since we ...
5 years, 1 month ago (2015-10-26 19:16:28 UTC) #3
kdzwinel
On 2015/10/26 at 19:16:28, paulirish wrote: > https://codereview.chromium.org/1409693007/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js > File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): > > https://codereview.chromium.org/1409693007/diff/1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode990 ...
5 years, 1 month ago (2015-10-26 21:51:30 UTC) #4
pfeldman
https://codereview.chromium.org/1409693007/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/1409693007/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js#newcode990 third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:990: contextMenu.appendItem(WebInspector.UIString.capitalize("Store ^node as ^global ^variable"), resolveNodeAndCall.bind(null, domNode, this._saveToTempVariable.bind(this))); It'd ...
5 years, 1 month ago (2015-10-29 23:50:34 UTC) #5
pfeldman
Something like this: https://codereview.chromium.org/1413593008
5 years, 1 month ago (2015-10-30 00:04:45 UTC) #6
kdzwinel
5 years, 1 month ago (2015-11-03 22:29:05 UTC) #7 
On 2015/10/30 at 00:04:45, pfeldman wrote:
> Something like this: https://codereview.chromium.org/1413593008

Thank you for taking time to review our code! I guess we bit more than we can
chew trying to fix that, we'll try to pick something smaller next time :)
Since your patch fixes the issue, I'm closing this one.

Powered by Google App Engine
This is Rietveld 408576698