Issue 1413593003: Merge to XFA: Consolidate test support code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413593003: Merge to XFA: Consolidate test support code. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Consolidate test support code. Original Review URL: https://codereview.chromium.org/1416713002 . (cherry picked from commit 6d34d056a7188b7ae9800fe3ceb68645e0442879) Conflicts: BUILD.gn samples/BUILD.gn samples/pdfium_test.cc samples/samples.gyp R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d831dc7147e9895185740f551fed7abe246e2adf

Patch Set 2 : remove explicit lpng dependency, its part of XFA Pdfium. #

Patch Set 3 : Remove stray merges. #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+280 lines, -230 lines)			Patch
M	BUILD.gn	View		4 chunks	+42 lines, -7 lines	0 comments	Download
M	pdfium.gyp	View		4 chunks	+31 lines, -2 lines	0 comments	Download
M	samples/BUILD.gn	View	1 2	3 chunks	+5 lines, -1 line	1 comment	Download
M	samples/pdfium_test.cc	View		6 chunks	+8 lines, -108 lines	0 comments	Download
M	samples/samples.gyp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	testing/embedder_test.cpp	View		5 chunks	+6 lines, -112 lines	0 comments	Download
A	testing/test_support.h	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	testing/test_support.cpp	View		1 chunk	+140 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/1413593003/diff/40001/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/1413593003/diff/40001/samples/BUILD.gn#newcode8 samples/BUILD.gn:8: testonly = true Do these need to be ...

5 years, 2 months ago (2015-10-19 22:53:43 UTC) #2

Tom Sepez

5 years, 2 months ago (2015-10-19 23:04:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
d831dc7147e9895185740f551fed7abe246e2adf (presubmit successful).