Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1413563007: Fix ScopedTempDir in content_unittests (Closed)

Created:
5 years, 2 months ago by jschuh
Modified:
5 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, wjmaclean, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, feature-media-reviews_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, cmumford, horo+watch_chromium.org, dgrogan, kinuko+watch, jsbell+idb_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ScopedTempDir in content_unittests Fix declaration order to prevent leaking Windows temp dirs. BUG=546640 TBR=jam Committed: https://crrev.com/e9ab4c6c38a64fe4dca8cef7589f3ca19feade54 Cr-Commit-Position: refs/heads/master@{#355727}

Patch Set 1 #

Patch Set 2 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/media/webrtc_identity_store_unittest.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 1 4 chunks +9 lines, -16 lines 0 comments Download
M content/browser/storage_partition_impl_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
jschuh
jam@ - This is just some minor constructor reordering to fix the leaking scoped temp ...
5 years, 2 months ago (2015-10-23 00:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413563007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413563007/1
5 years, 2 months ago (2015-10-23 00:15:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/113276) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-23 00:27:11 UTC) #7
jschuh
Hitting moving targets is fun.
5 years, 2 months ago (2015-10-23 01:02:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413563007/10009 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413563007/10009
5 years, 2 months ago (2015-10-23 01:03:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/70389)
5 years, 2 months ago (2015-10-23 01:24:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413563007/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413563007/30001
5 years, 2 months ago (2015-10-23 03:45:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 2 months ago (2015-10-23 04:25:43 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 04:26:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9ab4c6c38a64fe4dca8cef7589f3ca19feade54
Cr-Commit-Position: refs/heads/master@{#355727}

Powered by Google App Engine
This is Rietveld 408576698