Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: content/browser/fileapi/file_system_url_request_job_unittest.cc

Issue 1413563007: Fix ScopedTempDir in content_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/file_system_url_request_job_unittest.cc
diff --git a/content/browser/fileapi/file_system_url_request_job_unittest.cc b/content/browser/fileapi/file_system_url_request_job_unittest.cc
index dca1c535083cb3f1ad89993a7c5cef303c2ec1b5..8e47e4e90c726740641cfa9885e437c6041b76cd 100644
--- a/content/browser/fileapi/file_system_url_request_job_unittest.cc
+++ b/content/browser/fileapi/file_system_url_request_job_unittest.cc
@@ -246,10 +246,12 @@ class FileSystemURLRequestJobTest : public testing::Test {
return GURL(kFileSystemURLPrefix + path);
}
- // Put the message loop at the top, so that it's the last thing deleted.
+ // Temp directory is at the top because it must be deleted last.
+ base::ScopedTempDir temp_dir_;
+
+ // The message loop must be deleted second to last.
base::MessageLoopForIO message_loop_;
- base::ScopedTempDir temp_dir_;
scoped_refptr<storage::FileSystemContext> file_system_context_;
net::URLRequestContext empty_context_;

Powered by Google App Engine
This is Rietveld 408576698