Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: content/public/browser/resource_request_info.h

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, add WebNavigationApiTest.CrossProcessIframe test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_request_info.h
diff --git a/content/public/browser/resource_request_info.h b/content/public/browser/resource_request_info.h
index e9ba86ebcc0ea4c99f84a8a312a818c429406a8c..b8980eb5aba90d7f872af1d014e0e394cb4ceda2 100644
--- a/content/public/browser/resource_request_info.h
+++ b/content/public/browser/resource_request_info.h
@@ -76,13 +76,9 @@ class ResourceRequestInfo {
// True if GetRenderFrameID() represents a main frame in the RenderView.
virtual bool IsMainFrame() const = 0;
- // True if GetParentRenderFrameID() represents a main frame in the RenderView.
+ // True if parent frame of frame represents a main frame in the RenderView.
Charlie Reis 2015/11/03 00:23:49 nit: True if the parent frame of the frame that se
robwu 2015/11/03 10:03:02 Done (using "the frame's parent" to fit the commen
virtual bool ParentIsMainFrame() const = 0;
- // Routing ID of parent frame of frame that sent this resource request.
- // -1 if unknown / invalid.
- virtual int GetParentRenderFrameID() const = 0;
-
// Returns the associated resource type.
virtual ResourceType GetResourceType() const = 0;

Powered by Google App Engine
This is Rietveld 408576698