content/public/browser/render_frame_host.h - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/render_frame_host.h

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add WebNavigationApiTest.CrossProcessIframe test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/render_frame_host.h

diff --git a/content/public/browser/render_frame_host.h b/content/public/browser/render_frame_host.h

index 7e769cb154ad7754de70a7559025c733556dfd8f..071ad636f9c4777c24ec7e7fb7bf19eaba880493 100644

--- a/content/public/browser/render_frame_host.h

+++ b/content/public/browser/render_frame_host.h

@@ -64,6 +64,9 @@ class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,

// current RenderFrameHost.

virtual RenderFrameHost* GetParent() = 0;

+ // Returns the FrameTreeNode ID for this frame.

+ virtual int GetFrameTreeNodeID() = 0;

// Returns the assigned name of the frame, the name of the iframe tag

// declaring it. For example, <iframe name="framename">[...]</iframe>. It is

// quite possible for a frame to have no name, in which case GetFrameName will