Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4209)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve port lifetime management, add tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index 6597f0efa99cbb815f0874b0217a7be994406543..4b97d47050bb8919aea0d2f0a35e1efeb7f7ff94 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -488,7 +488,6 @@ bool WebNavigationGetFrameFunction::RunSync() {
EXTENSION_FUNCTION_VALIDATE(params.get());
int tab_id = params->details.tab_id;
int frame_id = params->details.frame_id;
- int process_id = params->details.process_id;
SetResult(base::Value::CreateNullValue());
@@ -513,7 +512,7 @@ bool WebNavigationGetFrameFunction::RunSync() {
content::RenderFrameHost* render_frame_host =
frame_id == 0 ? web_contents->GetMainFrame()
- : content::RenderFrameHost::FromID(process_id, frame_id);
+ : content::RenderFrameHost::FromFrameTreeNodeID(frame_id);
if (!frame_navigation_state.IsValidFrame(render_frame_host))
return true;

Powered by Google App Engine
This is Rietveld 408576698