chrome/browser/extensions/api/messaging/native_message_port.cc - Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_port.cc

Issue 1413543005: Use FrameTreeNode ID as frameId in extension APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve port lifetime management, add tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/messaging/native_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_port.cc b/chrome/browser/extensions/api/messaging/native_message_port.cc

index 8d26d306b144f2f5716cc62c38121c83cb696394..77b42d58ad9c1a0a15d8a5095f9b68b84dcee70b 100644

--- a/chrome/browser/extensions/api/messaging/native_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_port.cc

@@ -100,9 +100,7 @@ NativeMessagePort::~NativeMessagePort() {

host_task_runner_->DeleteSoon(FROM_HERE, core_.release());

}

-void NativeMessagePort::DispatchOnMessage(

- const Message& message,

- int target_port_id) {

+void NativeMessagePort::DispatchOnMessage(const Message& message) {

DCHECK(thread_checker_.CalledOnValidThread());

core_->OnMessageFromChrome(message.data);

}