Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5728)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller.h

Issue 1413533009: Make the new Gaia password separated signin flow modal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac build Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/signin_view_controller.h
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller.h b/chrome/browser/ui/views/profiles/signin_view_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..64548bae6b93e86da4d10aa1dbe6b92bd6ba3e45
--- /dev/null
+++ b/chrome/browser/ui/views/profiles/signin_view_controller.h
@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_
+#define CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_
+
+#include "chrome/browser/ui/profile_chooser_constants.h"
+#include "content/public/browser/web_contents_delegate.h"
+
+class Browser;
+class Profile;
+
+namespace views {
+class WebView;
+class Widget;
+};
sky 2015/11/25 00:30:07 nit: no ;
anthonyvd 2015/11/25 18:49:31 Done.
+
+class SigninViewController : public content::WebContentsDelegate {
+ public:
+ SigninViewController() : modal_signin_widget_(nullptr) {}
+ static views::WebView* CreateGaiaWebView(WebContentsDelegate* delegate,
sky 2015/11/25 00:30:07 somewhitespacewouldbenice. And some comments too.
anthonyvd 2015/11/25 18:49:31 Done.
+ profiles::BubbleViewMode mode,
+ Profile* profile);
+ void ShowModalSignin(profiles::BubbleViewMode mode, Browser* browser);
+ void CloseModalSignin();
+ static bool ShouldShowModalSigninForMode(profiles::BubbleViewMode mode);
+
+ private:
+ views::Widget* modal_signin_widget_; // Not owned.
sky 2015/11/25 00:30:07 Should this be closed if the destructor is hit and
anthonyvd 2015/11/25 18:49:31 Done.
+};
sky 2015/11/25 00:30:07 DISALLOW...
anthonyvd 2015/11/25 18:49:31 Done.
+
+#endif // CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698