Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: chrome/browser/ui/views/profiles/signin_view_controller.h

Issue 1413533009: Make the new Gaia password separated signin flow modal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac build Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_
7
8 #include "chrome/browser/ui/profile_chooser_constants.h"
9 #include "content/public/browser/web_contents_delegate.h"
10
11 class Browser;
12 class Profile;
13
14 namespace views {
15 class WebView;
16 class Widget;
17 };
sky 2015/11/25 00:30:07 nit: no ;
anthonyvd 2015/11/25 18:49:31 Done.
18
19 class SigninViewController : public content::WebContentsDelegate {
20 public:
21 SigninViewController() : modal_signin_widget_(nullptr) {}
22 static views::WebView* CreateGaiaWebView(WebContentsDelegate* delegate,
sky 2015/11/25 00:30:07 somewhitespacewouldbenice. And some comments too.
anthonyvd 2015/11/25 18:49:31 Done.
23 profiles::BubbleViewMode mode,
24 Profile* profile);
25 void ShowModalSignin(profiles::BubbleViewMode mode, Browser* browser);
26 void CloseModalSignin();
27 static bool ShouldShowModalSigninForMode(profiles::BubbleViewMode mode);
28
29 private:
30 views::Widget* modal_signin_widget_; // Not owned.
sky 2015/11/25 00:30:07 Should this be closed if the destructor is hit and
anthonyvd 2015/11/25 18:49:31 Done.
31 };
sky 2015/11/25 00:30:07 DISALLOW...
anthonyvd 2015/11/25 18:49:31 Done.
32
33 #endif // CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698