Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.h

Issue 1413523007: Simplify computation of the invalidation rect for a frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPluginContainerImpl.h
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.h b/third_party/WebKit/Source/web/WebPluginContainerImpl.h
index 131eb183a0bd4bc5ab57267e3e3b6dbdaed51d6c..e65e6913fefb41b41633619735f98d28232ed013 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.h
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.h
@@ -165,6 +165,10 @@ public:
#endif
private:
+ // Sets |clippedAbsoluteRect| to the absolute visible rect for the plugin, clipped to the visible screen of the root frame.
chrishtr 2015/11/03 19:22:55 This is my understanding of what is intended after
tommycli 2015/11/03 20:10:22 Exactly. One is clipped to the visible viewport, t
+ // If not null, sets |unclippedAbsoluteRect| tp the absolute visible rect for the plugin (but without also clipping to the screen).
tommycli 2015/11/03 20:10:22 Tiny typo.
chrishtr 2015/11/03 21:24:56 Fixed.
+ void computeClipRectsForPlugin(const HTMLFrameOwnerElement* pluginOwnerElement, IntRect& clippedAbsoluteRect, IntRect* unclippedAbsoluteRect) const;
+
WebPluginContainerImpl(HTMLPlugInElement*, WebPlugin*);
~WebPluginContainerImpl() override;

Powered by Google App Engine
This is Rietveld 408576698