Simplify computation of the invalidation rect for a frame.

third_party/WebKit/Source/web/WebPluginContainerImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2014 Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 147 matching lines @@
 
     DECLARE_VIRTUAL_TRACE();
     void dispose() override;
 
 #if ENABLE(OILPAN)
     LocalFrame* pluginFrame() const override { return frame(); }
     void shouldDisposePlugin() override;
 #endif
 
 private:
+    // Sets |clippedAbsoluteRect| to the absolute visible rect for the plugin, clipped to the visible screen of the root frame.

[chrishtr, 2015/11/03 19:22:55]

This is my understanding of what is intended after reading the old code. Is it
correct?

i.e. we want to compute the pixels in the root view of the document, bot clipped
to the visible viewport, and not clipped to it.

[tommycli, 2015/11/03 20:10:22]

Exactly. One is clipped to the visible viewport, the other pretends that the
user's monitor can show the whole webpage.

+    // If not null, sets |unclippedAbsoluteRect| tp the absolute visible rect for the plugin (but without also clipping to the screen).

[tommycli, 2015/11/03 20:10:22]

Tiny typo.

[chrishtr, 2015/11/03 21:24:56]

Fixed.

+    void computeClipRectsForPlugin(const HTMLFrameOwnerElement* pluginOwnerElement, IntRect& clippedAbsoluteRect, IntRect* unclippedAbsoluteRect) const;
+
     WebPluginContainerImpl(HTMLPlugInElement*, WebPlugin*);
     ~WebPluginContainerImpl() override;
 
     void handleMouseEvent(MouseEvent*);
     void handleDragEvent(MouseEvent*);
     void handleWheelEvent(WheelEvent*);
     void handleKeyboardEvent(KeyboardEvent*);
     void handleTouchEvent(TouchEvent*);
     void handleGestureEvent(GestureEvent*);
 
@@ skipping 32 matching lines @@
 };
 
 DEFINE_TYPE_CASTS(WebPluginContainerImpl, Widget, widget, widget->isPluginContainer(), widget.isPluginContainer());
 // Unlike Widget, we need not worry about object type for container.
 // WebPluginContainerImpl is the only subclass of WebPluginContainer.
 DEFINE_TYPE_CASTS(WebPluginContainerImpl, WebPluginContainer, container, true, true);
 
 } // namespace blink
 
 #endif