Issue 1413493002: Add steps for Contributing Code to README.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413493002: Add steps for Contributing Code to README.md (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add steps for Contributing Code to README.md R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/313cf59d5cd5c314fea904019923d97bfc9f315c

Patch Set 2 : Security template link #

Patch Set 5 : Move bugs to its own section. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
	M	README.md	View	1 2 3 4	1 chunk	+39 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/1413493002/diff/40001/README.md File README.md (right): https://codereview.chromium.org/1413493002/diff/40001/README.md#newcode79 README.md:79: [bug tracker](https://code.google.com/p/pdfium/issues/list), but for security bugs, do we ...

5 years, 2 months ago (2015-10-15 22:50:38 UTC) #3

Tom Sepez

On 2015/10/15 22:50:38, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1413493002/diff/40001/README.md > File README.md (right): ...

5 years, 2 months ago (2015-10-15 22:54:01 UTC) #4

Tom Sepez

5 years, 2 months ago (2015-10-15 22:54:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
313cf59d5cd5c314fea904019923d97bfc9f315c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1413493002: Add steps for Contributing Code to README.md (Closed)

Description

Patch Set 1 #

Patch Set 2 : Security template link #

Patch Set 3 : Tidy #

Patch Set 4 : 80 cols. #

Patch Set 5 : Move bugs to its own section. #

Messages