Chromium Code Reviews Chromium Code Reviews
Issue 1413493002:
Add steps for Contributing Code to README.md (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@master| OLD | NEW |
|---|---|
| 1 # Building PDFium | 1 # Building PDFium |
| 2 | 2 |
| 3 ## Prerequisites | 3 ## Prerequisites |
| 4 | 4 |
| 5 Get the chromium depot tools via the instructions at | 5 Get the chromium depot tools via the instructions at |
| 6 http://www.chromium.org/developers/how-tos/install-depot-tools (this provides | 6 http://www.chromium.org/developers/how-tos/install-depot-tools (this provides |
| 7 the gclient utilty needed below). | 7 the gclient utilty needed below). |
| 8 | 8 |
| 9 Also install Python, Subversion, and Git and make sure they're in your path. | 9 Also install Python, Subversion, and Git and make sure they're in your path. |
| 10 | 10 |
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 62 The pdfium\_test program supports reading, parsing, and rasterizing the pages of | 62 The pdfium\_test program supports reading, parsing, and rasterizing the pages of |
| 63 a .pdf file to .ppm or .png output image files (windows supports two other | 63 a .pdf file to .ppm or .png output image files (windows supports two other |
| 64 formats). For example: `out/Debug/pdfium_test --ppm path/to/myfile.pdf | 64 formats). For example: `out/Debug/pdfium_test --ppm path/to/myfile.pdf |
| 65 ` | 65 ` |
| 66 | 66 |
| 67 ## Waterfall | 67 ## Waterfall |
| 68 | 68 |
| 69 The current health of the source tree can be found at | 69 The current health of the source tree can be found at |
| 70 http://build.chromium.org/p/client.pdfium/console | 70 http://build.chromium.org/p/client.pdfium/console |
| 71 | 71 |
| 72 ## Contributing code | |
| 73 | |
| 74 For contributing code, we will follow | |
| 75 [Chromium's process](http://dev.chromium.org/developers/contributing-code) | |
| 76 as much as possible. The main exceptions are: | |
| 77 | |
| 78 1. We will be using this | |
| 79 [bug tracker](https://code.google.com/p/pdfium/issues/list), but for security bu gs, | |
|
Lei Zhang
2015/10/15 22:50:38
do we stick with 80 cols?
| |
| 80 please use [Chromium's security bug template] | |
| 81 (https://code.google.com/p/chromium/issues/entry?template=Security%20Bug) | |
| 82 and add the "Cr-Internals-Plugins-PDF" label. | |
| 83 2. Code has to conform to the existing style and not Chromium/Google style. | |
| 84 3. There is no commit queue, approved committers can land their changes via `git cl land` | |
| 85 4. Changes must be merged to the XFA branch as well (see below). | |
| 86 | |
| 72 ## Branches | 87 ## Branches |
| 73 | 88 |
| 74 There is a branch for a forthcoming feature called XFA that you can get by | 89 There is a branch for a forthcoming feature called XFA that you can get by |
| 75 following the steps above, then: `git checkout origin/xfa build/gyp_pdfium ninja | 90 following the steps above, then: |
| 76 -C out/Debug | 91 |
| 77 ` | 92 ``` |
| 93 git checkout origin/xfa | |
| 94 build/gyp_pdfium | |
| 95 ninja -C out/Debug | |
| 96 ``` | |
| 97 | |
| 98 Merging to XFA requires: | |
| 99 | |
| 100 ``` | |
| 101 git checkout origin/xfa | |
| 102 git checkout -b merge_branch | |
| 103 git branch --set-upstream-to=origin/xfa | |
| 104 git cherry-pick -x <commit hash> | |
| 105 git commit --amend # add Merge to XFA | |
| 106 git cl upload | |
| 107 ``` | |
| 108 | |
| 109 Then wait for approval, and `git cl land` | |
| OLD | NEW |
