Issue 1413403007: Wait for InstrumentationService.shutdown() before exit(0).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413403007: Wait for InstrumentationService.shutdown() before exit(0). (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Wait for InstrumentationService.shutdown() before exit(0). Otherwise we don't get the last portion of instrumentation data in the file at all. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d49d0f7e06016719c5243f6bd89b788f7eb1d388

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -12 lines)			Patch
M	pkg/analysis_server/lib/src/server/driver.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/instrumentation/file_instrumentation.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/instrumentation/instrumentation.dart	View	6 chunks	+8 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/instrumentation/instrumentation_test.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-11-04 18:08:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d49d0f7e06016719c5243f6bd89b788f7eb1d388 (presubmit successful).