pkg/analyzer/lib/instrumentation/file_instrumentation.dart - Issue 1413403007: Wait for InstrumentationService.shutdown() before exit(0).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/instrumentation/file_instrumentation.dart

Issue 1413403007: Wait for InstrumentationService.shutdown() before exit(0). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/instrumentation/file_instrumentation.dart

diff --git a/pkg/analyzer/lib/instrumentation/file_instrumentation.dart b/pkg/analyzer/lib/instrumentation/file_instrumentation.dart

index ba23b68f3b5dfe502e462f7d0410305daeac054d..72691156d66f7d7248305e3aa5d17c5f9420ca1f 100644

--- a/pkg/analyzer/lib/instrumentation/file_instrumentation.dart

+++ b/pkg/analyzer/lib/instrumentation/file_instrumentation.dart

@@ -4,6 +4,7 @@

library file_instrumentation;

+import 'dart:async';

import 'dart:io';

import 'package:analyzer/instrumentation/instrumentation.dart';

@@ -30,8 +31,8 @@ class FileInstrumentationServer implements InstrumentationServer {

}

@override

- void shutdown() {

- _sink.close();

+ Future shutdown() async {

+ await _sink.close();

_sink = null;

}