Issue 1413373013: Quic streams honor RST_STREAM + NO_ERROR on the write side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413373013: Quic streams honor RST_STREAM + NO_ERROR on the write side. (Closed)

Created:
5 years, 1 month ago by rjshade

Modified:
5 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@106851267

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Quic streams honor RST_STREAM + NO_ERROR on the write side. Override QuicDataStream CloseWriteSide method to honor QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 or later versions: send rst stream when writing to a stream initiated by the peer is finished but incoming data hasn't been received completely. Merge internal change: 106853342 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+272 lines, -50 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	7 chunks	+122 lines, -4 lines	0 comments	Download
M	net/quic/quic_spdy_stream.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_spdy_stream.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	net/quic/reliable_quic_stream.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2 chunks	+47 lines, -18 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream_test.cc	View	11 chunks	+70 lines, -26 lines	0 comments	Download

Depends on Patchset:

Issue 1435553004 Patch 1

Dependent Patchsets:

Issue 1433783003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

5 years, 1 month ago (2015-11-10 21:37:58 UTC) #2

I'm surprised that no chromium tests needed to change. Yay!

lgtm

Expand Messages | Collapse Messages