net/quic/reliable_quic_stream.cc - Issue 1413373013: Quic streams honor RST_STREAM + NO_ERROR on the write side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 1413373013: Quic streams honor RST_STREAM + NO_ERROR on the write side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106851267

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/reliable_quic_stream.cc

diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc

index a7279a6f2a6b983426ac518461d355708593ed36..1efad1902607faa34274df5b90918cff9dc5c2a9 100644

--- a/net/quic/reliable_quic_stream.cc

+++ b/net/quic/reliable_quic_stream.cc

@@ -181,7 +181,6 @@ void ReliableQuicStream::OnFinRead() {

}

void ReliableQuicStream::Reset(QuicRstStreamErrorCode error) {

- DCHECK_NE(QUIC_STREAM_NO_ERROR, error);

stream_error_ = error;

// Sending a RstStream results in calling CloseStream.

session()->SendRstStream(id(), error, stream_bytes_written_);

« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »