Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1413373007: CC AnimationHost: Fix LinkHighlights detach scope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GC. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/LinkHighlightImplTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 2a1421fcebcdfe88fdb3f5540a407512fabf53ca..0114670454c6b84d1525cafc0230ac5216c6b476 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2681,6 +2681,7 @@ bool WebViewImpl::isAcceleratedCompositingActive() const
void WebViewImpl::willCloseLayerTreeView()
{
if (m_linkHighlightsTimeline) {
+ m_linkHighlights.clear();
pdr. 2015/11/04 02:53:02 Can you help me understand this line? Why do we on
loyso (OOO) 2015/11/04 04:16:30 Ermmm. We can clear m_linkHighlights in any case,
detachCompositorAnimationTimeline(m_linkHighlightsTimeline.get());
m_linkHighlightsTimeline.clear();
}
« no previous file with comments | « third_party/WebKit/Source/web/LinkHighlightImplTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698