CC AnimationHost: Fix LinkHighlights detach scope.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2663 matching lines @@
 }
 
 bool WebViewImpl::isAcceleratedCompositingActive() const
 {
     return m_rootLayer;
 }
 
 void WebViewImpl::willCloseLayerTreeView()
 {
     if (m_linkHighlightsTimeline) {
+        m_linkHighlights.clear();

[pdr., 2015/11/04 02:53:02]

Can you help me understand this line? Why do we only clear m_linkHighlights if
there's a highlight timeline?

[loyso (OOO), 2015/11/04 04:16:30]

Ermmm. We can clear m_linkHighlights in any case, definitely.

Currently two compositor animation systems co-exist in cc.
m_linkHighlightsTimeline presence indicates that we are running in "external
AnimatioHost mode (enable-compositor-animationtimelines).

So i just wanted to keep those behaviors isolated.

         detachCompositorAnimationTimeline(m_linkHighlightsTimeline.get());
         m_linkHighlightsTimeline.clear();
     }
 
     if (page())
         page()->willCloseLayerTreeView();
 
     setRootGraphicsLayer(nullptr);
     m_layerTreeView = nullptr;
 }
@@ skipping 1772 matching lines @@
     if (m_pageColorOverlay)
         m_pageColorOverlay->update();
     if (InspectorOverlay* overlay = inspectorOverlay()) {
         PageOverlay* inspectorPageOverlay = overlay->pageOverlay();
         if (inspectorPageOverlay)
             inspectorPageOverlay->update();
     }
 }
 
 } // namespace blink